Open meirkeller opened 5 months ago
To reproduce the first issue regarding the incorrect import statement, follow these steps:
import { Node, printNode } from '@ovotech/ts-compose';
// Debugging the issue: These args represent the parameters passed down to the import function call
const args = {
allAs: undefined,
defaultAs: undefined,
module: './external-Address',
named: [
{
name: "MyNamespaceData",
as: "MyNamespaceDataAddress",
},
]
};
console.log(printNode(Node.Import(args)));
Expected output:
import { type MyNamespaceData as MyNamespaceDataAddress } from "./external-Address";
However, you will observe the following output along with deprecation warnings:
DeprecationWarning: 'createImportClause' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createImportDeclaration' has been deprecated since v4.8.0. Decorators are no longer supported for this function. Callers should switch to an overload that does not accept a 'decorators' parameter.
import { type MyNamespaceDataAddress as } from "./external-Address";
Hi :) I've downgraded the package to version 5.1.0, and it seems to work fine.
@orpilosof21 Thanks!
Hi!
I face the same issue but with the avro-ts-cli
:
DeprecationWarning: 'createPropertySignature' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createInterfaceDeclaration' has been deprecated since v4.8.0. Decorators are no longer supported for this function. Callers should switch to an overload that does not accept a 'decorators' parameter.
DeprecationWarning: 'createParameterDeclaration' has been deprecated since v4.8.0. Decorators have been combined with modifiers. Callers should switch to an overload that does not accept a 'decorators' parameter.
import { type XtypeSnow_syncSnow_record_xusEventExternalV1DataUsRusBaseV1 as } from "./us_rus_base.avsc";
Node version: v18.16.1 Typescript version: 5.3.3 @ovotech/avro-ts-cli: 3.6.0
I'm currently working with the external example in the repository.
Upon executing the script, I encountered the following output:
There are two issues identified in the output:
import { type MyNamespaceDataAddress as } from "./external-Address";
is incorrect and should be replaced withimport { type MyNamespaceData } from "./external-Address";
.address
in theCreateUser
interface is declared asMyNamespaceDataAddress.Address
, but it should beMyNamespaceData.Address
.These corrections would ensure the code functions as intended.
Node version: v18.19.0 Typescript version: 5.4.2 Using default tsconfig