search

ovotech / circleci-orbs

CircleCI Orbs
MIT License
52 stars 37 forks source link

update tf orb #433

Closed robturner-kaluza closed 2 years ago

Adam-McDevitt commented 2 years ago

I think you'll need to include a version number bump in this

Adam-McDevitt commented 2 years ago

found this PR as I happen to be looking into the same thing just now :)

robturner-kaluza commented 2 years ago

I think you'll need to include a version number bump in this

ah yeah just testing this out for now. still getting this error:

Error: Unsupported Terraform Core version

on .terraform/modules/core_datadog/versions.tf line 7, in terraform: 7: required_version = "~> 0.14"

Module module.core_datadog (from terraform.ovotech.org.uk/jaws/jaws-datadog/jaws) does not support Terraform version 0.13.6. To proceed, either choose another supported Terraform version or update this version constraint. Version constraints are normally set for good reason, so updating the constraint may lead to other errors or unexpected behavior.

think I may need to update the jaws terraform module as well

Adam-McDevitt commented 2 years ago

Yeah I saw a similar thing on our price change service which is currently a blocker for me, to happy to support in getting this merged in if there's anything I could do to help.

Adam-McDevitt commented 2 years ago

should it maybe be a minor version bump if its dependency is a minor bump too?