search

ovotech / circleci-orbs

CircleCI Orbs
MIT License
52 stars 37 forks source link

[RNC-2769] Add optional prod approval step to release #478

Open jensraaby opened 2 years ago

jensraaby commented 2 years ago

This needs testing (assuming I can remember how to reference the orb by git branch)

tomp4l commented 2 years ago

Spoke to soon, it's not valid schema :cry:

jensraaby commented 2 years ago

Spoke to soon, it's not valid schema 😢

You're too quick! I didn't realise it would add reviewers to the PR straight away.

It looks like I can't add a conditional "job" to another job, so I'm back to square one. The "release" job was the original deploy workflow for everything until incident-gate. I noticed with the neo facade that the template was using it, so I was hoping rather than wiring together a whole new job I'd be able to just add in the approval bit as optional (in case something else is using it and we don't want to add manual approval).

tomp4l commented 2 years ago

Makes sense, shame we can't do it like this, it looked sensible