ovotech / circleci-orbs

CircleCI Orbs
MIT License
52 stars 37 forks source link

BREAKING CHANGE: allowing usage of oidc instead of aws keys if specified #490

Closed RostamKal closed 1 year ago

RostamKal commented 1 year ago

upversioning to circleci/aws-ecr@8.1.3 and allowing usage of oidc instead of aws keys/secrets if specified This version uses oidc for the relevant jobs if the oidc parameter is set to true. Otherwise it will look for AWS keys as before by default The newer aws-ecr version uses a newer docker version + buildx which doesn't seem to work with the deprecated github container repo url (docker.pkg.github.com). It fails to pull images with 401's despite a login using the same url. So i've changed the login to use the new url (ghcr.io). This is the breaking part of the change and requires any github container repo urls in dockerfiles to be amended to ghcr.io

NEW CONTEXT VARIABLES USED

CIRCLE_IAM_ROLE_ARN (optional) AWS_ACCOUNT_ID (already in jaws contexts)

DEPRECATED CONTEXT VARIABLES

ACCOUNT_URL