fix: add traces to updates with generared keys

ovotech / natchez-extras

Integrations between Natchez, Doobie, HTTP4s, Log4cats and Datadog. Formerly called effect-utils.

https://ovotech.github.io/natchez-extras/

Apache License 2.0

31 stars 18 forks source link

fix: add traces to updates with generared keys #112

Closed ajkaanbal closed 9 months ago

ajkaanbal commented 1 year ago

I was having trouble tracing updates using withUniqueGeneratedKeys, these changes appear to have solved the problem so far.

voidcontext commented 11 months ago

@ajkaanbal Could you please describe the issue / symptom you were experiencing?

richard-dennehy-ovo commented 10 months ago

Hi @voidcontext, I believe we ran into the same issue; queries using withUniqueGeneratedKeys don't appear to get traced at all, e.g. https://github.com/ovotech/carbon-zero-ingestor/blob/b58cc5ac51d2aab28d69a284b34f09d99ecd9877/service/src/main/scala/com/ovoenergy/carbonzero/ds/billbreakdown/weekly/BillBreakdownWeeklyStorage.scala#L97

voidcontext commented 9 months ago

HI @ajkaanbal and @richard-dennehy-ovo, I had some time today so I added the suggested changes in #114 and merged it, I'll tag a fix release soon, it should be available in maven later today.