Support span.type, prevent Datadog sampling traces

ovotech / natchez-extras

Integrations between Natchez, Doobie, HTTP4s, Log4cats and Datadog. Formerly called effect-utils.

https://ovotech.github.io/natchez-extras/

Apache License 2.0

31 stars 18 forks source link

Support span.type, prevent Datadog sampling traces #37

Closed tomverran closed 4 years ago

tomverran commented 4 years ago

This PR does three things

Maps a span.type tag into a type field on when we submit traces to Datadog
Adds a magic metric that should prevent Datadog only keeping a sample of our traces*
Adds an X-DataDog-Trace-Count header to stop the agent logging warnings all the time

* This could be made configurable in the future but none of the services using this library to my knowledge have enough traffic to require us to drop some traces

ericaovo commented 4 years ago

what are you referring to with sample of our traces?

tomverran commented 4 years ago

If you have an app with lots of traffic you can ask the Datadog agent to only submit a sample of the traces it recieves up to Datadog: https://docs.datadoghq.com/tracing/guide/trace_sampling_and_storage/?tab=java