ovr / phpsa

Smart/Static Analyzer(sis) for PHP :bowtie::neckbeard:
Other
638 stars 77 forks source link

Change default values of MissingDocblock analyzer #291

Closed ddmler closed 7 years ago

ddmler commented 7 years ago

Hey!

Type: bug fix

Link to issue:

This pull request affects the following components (please check boxes):

In raising this pull request, I confirm the following (please check boxes):

Small description of change:

@ovr changed default values of missingdocblock but only in .yml file. When I called "make analyzers" the command changed them back, so with this the changes are permanent.

ovr commented 7 years ago

Oops! It was my bad when I disable default values inside config not in Analyzer configuration :(

@ddmler btw, Looks Like we should enable all analyzer's values for testing...

ddmler commented 7 years ago

@ovr oh yeah i forgot that :smile:

ovr commented 7 years ago

Fixed inside master with your commit and additional commit Thanks