Remove duplicate methods through inheritance - Githubissues

ovr / phpsa

Smart/Static Analyzer(sis) for PHP :bowtie::neckbeard:

Other

638 stars 77 forks source link

Remove duplicate methods through inheritance #303

Closed ddmler closed 7 years ago

ddmler commented 7 years ago

Hey!

Type: code quality

Link to issue:

This pull request affects the following components (please check boxes):

[x] Core
[ ] Analyzer
[ ] Compiler
[ ] Control Flow Graph
[ ] Documentation

In raising this pull request, I confirm the following (please check boxes):

[x] I have read and understood the Contributing Guidelines.
[x] I have checked that another pull request for this purpose does not exist.
[ ] I wrote some tests for this PR.

Small description of change:

See: https://github.com/ovr/phpsa/blob/master/src/Definition/ParentDefinition.php#L39

and: https://github.com/ovr/phpsa/blob/master/src/Definition/AbstractDefinition.php#L37

the methods are already inherited, so we don't need them.

ovr commented 7 years ago

Thanks 🍕 🍰