ovr / phpsa

Smart/Static Analyzer(sis) for PHP :bowtie::neckbeard:
Other
638 stars 77 forks source link

Feature(Compose): Use latest symfony/config, fix #348 #349

Closed EvgenyOrekhov closed 6 years ago

EvgenyOrekhov commented 6 years ago

Hey!

Type: new feature

Link to issue: #348

This pull request affects the following components (please check boxes):

In raising this pull request, I confirm the following (please check boxes):

Small description of change:

The only breaking change in symfony/config 4.0.0 is

removed ConfigCachePass.

I didn't find any usages of ConfigCachePass in PHPSA, so I just bumped the version.

Thanks

EvgenyOrekhov commented 6 years ago

Failed on PHP 7.0 with the following message:

symfony/config v4.0.4 requires php ^7.1.3 -> your PHP version (7.0.25) does not satisfy that requirement

Solution: drop support for PHP <7.1.3.

EvgenyOrekhov commented 6 years ago

I fixed compatibility with PHP 7.0.

EvgenyOrekhov commented 6 years ago

Should I rebase?

ddmler commented 6 years ago

Thanks for fixing this @EvgenyOrekhov 👍