search

ovro-eovsa / ovro-lwa-solar

Calibration, imaging, and analysis of solar data taken by the Owens Valley Long Wavelength Array (OVRO-LWA)
MIT License
5 stars 6 forks source link

Fast vis source subtraction #85

Closed surajit4444mondal closed 6 months ago

surajit4444mondal commented 6 months ago

Changes made to support #82

peijin94 commented 6 months ago

The PR looks all good to me.

minor comment: in image_ms(), the variable "delete" is not used in source_substraction.py the elif in Line 230 and Line 222 are mutually exclusive to each other, so line 230 can be replaced by an 'else'.

surajit4444mondal commented 6 months ago

Thank you Peijin for the suggestions. The variable "delete" should be used to used to delete the model as is done in image_ms_quick. I have added those lines to image_ms. I also added delete_allsky and sky_image variables to image_ms. I agree with you that the lines you pointed in source_subtraction can be replaced with "else". I have now changed the code accordingly.