search

ow2-proactive / webhook-addons

Webhook tasks for ProActive workflows
0 stars 6 forks source link

Webhook class crashes if response is malformed #2

Open tobwiens opened 8 years ago

tobwiens commented 8 years ago

The webhook class crashes if the response is malformed.

Let the webhook class connect to ncat:

ncat -l 8099
// Please fill variables
String method = "POST"
String url = "http://localhost:8099/notification-service/notifications"
String headers = "{key0 = value0}" //Example: "{key0 = value0, key1 = value1, ...}"
String content = "{\n" +
"\"date\": \"2016-08-17T08:30:22.862Z\" \n" +
"\"description\": \"some description\",\n" +
"\"notificationId\": 0\n" +
"}"

// Don't change code below
import org.ow2.proactive.addons.webhook.Webhook;
Webhook.execute ( method, url, headers, content);

Following exception is thrown:

168t0@trydev.activeeon.com;12:36:25] POST Response Code :: -1 
[168t0@trydev.activeeon.com;12:36:25] Failed to execute task: javax.script.ScriptException: org.ow2.proactive.addons.webhook.exception.UnsuccessfulRequestException: POST Response Code :: -1 
[168t0@trydev.activeeon.com;12:36:25] at org.ow2.proactive.scheduler.task.executors.InProcessTaskExecutor.execute(InProcessTaskExecutor.java:195) 
[168t0@trydev.activeeon.com;12:36:25] at org.ow2.proactive.scheduler.task.executors.InProcessTaskExecutor.execute(InProcessTaskExecutor.java:134) 
[168t0@trydev.activeeon.com;12:36:25] at org.ow2.proactive.scheduler.task.executors.forked.env.ExecuteForkedTaskInsideNewJvm.fromForkedJVM(ExecuteForkedTaskInsideNewJvm.java:88) 
[168t0@trydev.activeeon.com;12:36:25] at org.ow2.proactive.scheduler.task.executors.forked.env.ExecuteForkedTaskInsideNewJvm.main(ExecuteForkedTaskInsideNewJvm.java:78) 
[168t0@trydev.activeeon.com;12:36:25] Caused by: org.ow2.proactive.scripting.ScriptException: javax.script.ScriptException: org.ow2.proactive.addons.webhook.exception.UnsuccessfulRequestException: POST Response Code :: -1 
[168t0@trydev.activeeon.com;12:36:25] at org.codehaus.groovy.jsr223.GroovyScriptEngineImpl.eval(GroovyScriptEngineImpl.java:159) 
[168t0@trydev.activeeon.com;12:36:25] at org.codehaus.groovy.jsr223.GroovyScriptEngineImpl.eval(GroovyScriptEngineImpl.java:130) 
[168t0@trydev.activeeon.com;12:36:25] at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:249) 
[168t0@trydev.activeeon.com;12:36:25] at org.ow2.proactive.scripting.Script.execute(Script.java:319) 
[168t0@trydev.activeeon.com;12:36:25] at org.ow2.proactive.scripting.ScriptHandler.handle(ScriptHandler.java:76) 
[168t0@trydev.activeeon.com;12:36:25] at org.ow2.proactive.scheduler.task.executors.InProcessTaskExecutor.execute(InProcessTaskExecutor.java:191) 
[168t0@trydev.activeeon.com;12:36:25] ... 3 more
tobwiens commented 8 years ago

@mbenguig Is that behavior intended? Or is it a bug?