search

owainlewis / clojure-mail

A Clojure library for parsing, downloading and reading email from IMAP servers.
203 stars 54 forks source link

several refactorings #35

Closed c-garcia closed 8 years ago

c-garcia commented 8 years ago
c-garcia commented 8 years ago

Dear Owain,

I have worked a little bit more on the code and done a couple of easy refactors. Besides the integration testing should be easier now, I have got lein eastwood to pass without warnings. Please, have a look and merge it if you think it is ok.

However, I would want to add some further features and I am not sure how they would impact your ideas on how the library is implemented. For instance, I would need to get all messages from a folder in read-write mode. However, to pass an option like :mode to the all-messages function is not possible because it is implemented as a multi-arity one. We faced the same issue when we added the target port to the store function.

I am extremely interested in how you would like to add these kind of options to the library. For your information, the application I have in mind will process e-mails one at a time and delete them if and only if the result of this process has been satisfactory.

Your ideas on this will be greatly appreciated.

Thanks and regards

owainlewis commented 8 years ago

Hi Cristobal,

Thanks for this. Happy to merge. Regarding your comment

I would want to add some further features and I am not sure how they would impact your ideas on how the library is implemented

I am happy to accept changes to this library and to be honest haven't really had much time to maintain it. So as long as the features make sense and would be useful to others I'm happy to accept changes.

Feel free to push any changes you may find useful.

Thanks

c-garcia commented 8 years ago

Hi

Thanks for your reply. I will send some new pull requests then as soon as I get some more time near the keyboard.

Have a nice weekend

Cristóbal