search

owaisrazaeng1 / nimble-test

0 stars 0 forks source link

[Chore] Increase test coverage #14

Open olivierobert opened 1 year ago

olivierobert commented 1 year ago

Issue

The core business logic (CSV upload, scraping) is not unit tested.

Expected

While 100% test coverage is not required for this code challenge, all critical paths of the application should be unit tested and ideally UI tested.

owaisrazaeng1 commented 1 year ago

Resolved in 9c36d65

olivierobert commented 1 year ago

I have added comments on #15

owaisrazaeng1 commented 1 year ago

resolved in https://github.com/owaisrazaeng1/nimble-test/commit/7aa833bd51593f376ce1c36a37c31e7b314e627f