search

owasp-modsecurity / ModSecurity

ModSecurity is an open source, cross platform web application firewall (WAF) engine for Apache, IIS and Nginx. It has a robust event-based programming language which provides protection from a range of attacks against web applications and allows for HTTP traffic monitoring, logging and real-time analysis.
https://www.modsecurity.org
Apache License 2.0
7.67k stars 1.54k forks source link

Clean up 'return' never will be executed. #3096

Closed gberkes closed 2 months ago

gberkes commented 2 months ago

Issue reference: https://sonarcloud.io/project/issues?open=AY1CfKFNrsSpWCKX0w9c&id=owasp-modsecurity_ModSecurity

There are three occurrences of this issue. I deleted pthread_exit(NULL) calls, because these execution points are not in pthread execution scope. In process_request() I kept pthread_exit(NULL) and deleted return(NULL), because here we are in pthread execution context. (FYI: 11.5 Thread Termination in Advanced Programming in the UNIX® Environment, Third Edition)

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud