search

owasp-modsecurity / ModSecurity

ModSecurity is an open source, cross platform web application firewall (WAF) engine for Apache, IIS and Nginx. It has a robust event-based programming language which provides protection from a range of attacks against web applications and allows for HTTP traffic monitoring, logging and real-time analysis.
https://www.modsecurity.org
Apache License 2.0
7.67k stars 1.54k forks source link

build: don't directly use the .libs directory #3097

Closed orbea closed 2 months ago

orbea commented 2 months ago

This is a duplicate of PR https://github.com/owasp-modsecurity/ModSecurity/pull/2980 to try to trigger the CI regression tests.

The build system should not directly use the .libs directory which is intended for internal use by the libtool implementation. Additionally when linking with internal a library the .la file should be used as this provides all the information required by the libtool implementation.

When using Slibtool instead of GNU Libtool the build fails because Slibtool is more strict about this and fails to find the required files to link with.

Gentoo Bug: https://bugs.gentoo.org/913484

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

orbea commented 2 months ago

Trying to split the changes in half didn't seem to make a difference for Quality Gate....

airween commented 2 months ago

Trying to split the changes in half didn't seem to make a difference for Quality Gate....

Yeah, QG check is very weird - I'm sure that's a false positive hit (the code is definitely not NEW).

I have to find a solution - sorry, and thanks for your patience.

orbea commented 2 months ago

I have to find a solution - sorry, and thanks for your patience.

No worries and thanks for your time!

airween commented 2 months ago

It sounds like a stupid question, but could you make a fresh clone and apply your modification in a separated new commit?

Here I see this:

modsec_duplicate

and may be Sonarcloud thinks that you added the mentioned lines through the pull. (Because 4d7d1fa3 was made in Sept, 2023)