Open romualdszkudlarek opened 1 year ago
fogs
commented
12 months ago The same issue exists when opening the official file in a German version of Excel. Reason seems to be indeed that Excel correctly translates function names but is unable to translate strings in formulas like "RC(-1)".
Also I can confirm that the POC implementation in this issue also works in my German Excel installation. Thanks @romualdszkudlarek
What needs to be done to get that update into the official download?
romualdszkudlarek
commented
12 months ago Hello @fogs , thanks for your feedback! We are currently investigating the issue and testing on other targeted languages to see if the problem also happens in languages other than French and German. We'll work on a fix when the issue is properly identified, that we will then publish. We'll keep the community posted.
fogs
commented
7 months ago A few month have passed - are you still investigating?
When trying to execute the SAMM Toolbox that can be downloaded from here: https://github.com/owaspsamm/core/releases/tag/v2.0.8 (Excel file, SAMM_spreadsheet.xlsx), functions are not executed; as a result, the Excel file opens, but all content remains static ("Ratings" in column J are not updated upon change in column F / "Answer"): the assessment is not run.
After investigation, this is due to the "RC" function used in the original Excel file not existing in Excel / French version. Replacing "RC(-1)" with "ADRESSE(LIGNE();COLONNE()-1)" gives positive results and the assessment is run (some other adaptations are needed, "RC" being used in some other locations with different arguments from -1, from example in the "Roadmap" tab.
As a proof-of-concept, I have fixed issues in the original Excel file using the "ADRESSE" function, that may be specific to the French version of Excel (see attached file): similar issues may be found in other languages, "ADRESSE" fixing the current issue only for French.
SAMM_spreadsheet_fr.xlsx