search

owebia / magento2-module-advanced-shipping

Other
90 stars 28 forks source link

proper access to method title in \Owebia\AdvancedShipping\Model\Carrier::getAllowedMethods #54

Closed adeptofvoltron closed 5 years ago

adeptofvoltron commented 5 years ago

Method \Owebia\AdvancedShipping\Model\Carrier::getAllowedMethods had a tricky error.

property \Owebia\AdvancedShipping\Model\Wrapper\RateResult\Method::title was returning value by magic method __get. However, forisset method, such property never existed, so isset was always returning false.

suggestions: Instead of my correction you can do something like: image but that would require changing required php version to 7^ in composer.json

@edit: greetings from cyclad team

owebia commented 5 years ago

Will be released in next version

owebia commented 5 years ago

@adeptofvoltron thanks for your feedback and the proposed PR