search

oweitman / ioBroker.squeezeboxrpc

This is an alternative Adapter that uses the JSON/RPC-Protokoll to get data and send commands to the Logitech Media Server.
MIT License
17 stars 8 forks source link

Fix state change for cmdGoTime state if provided value is a number #74

Closed kairauer closed 3 months ago

kairauer commented 7 months ago

Hi oweitman, first of all: awesome ioBroker adapter!

The issue I encountered one issue when using the ioBroker.simple-api adapter. This adapter allows to set any ioBroker state value with a HTTP API. Every squeezeboxrpc state I want to set via API works fine, except for cmdGoTime. This state is defined as "string", I assume thats because it can be set as a absolute time in seconds and a relative time like "+50" or "-50". When I set the absolute time in seconds via the HTTP API, that value is always casted to a number.

The solution If the provided value is a number, we could simply cast this to a string. Then, the state.val.trim() will not fail with a exception (trim() is not available for type number).

oweitman commented 3 months ago

in next version this change is included