owen-it / laravel-auditing

Record the change log from models in Laravel
https://laravel-auditing.com
MIT License
3.05k stars 390 forks source link

Fix namespace for phpstan #809

Closed erikn69 closed 1 year ago

erikn69 commented 1 year ago

This was fixed on https://github.com/owen-it/laravel-auditing/pull/798/commits/6ebf17b875600340270351fa7d29138f4ea3fdd2 But it was break again on https://github.com/owen-it/laravel-auditing/pull/798/commits/b7f358a4bc6a09a6bfe3e839185896ad1bded895, https://github.com/owen-it/laravel-auditing/commit/37453d12f95cbca1a95a31e0b681b9474609453c Was introduced on https://github.com/owen-it/laravel-auditing/pull/734 Closes #808

SanderMuller commented 1 year ago

I found the culprint which caused the error for which I made #808, we added a scope on this audits relation which was the source of erroring out, if I manually add a return type via docblock to that method, then the error is gone.

So our codebase should be ready for this PR to be merged