search

owen-it / laravel-auditing

Record the change log from models in Laravel
https://laravel-auditing.com
MIT License
3.05k stars 390 forks source link

PHP Code Standard #975

Open rajmundtoth0 opened 1 month ago

rajmundtoth0 commented 1 month ago

I have extracted the PHP CS part from the v14-dev branch, as this one can be included in v13, the biggest changes are the strict options in some cases.

willpower232 commented 1 month ago

Thanks for the effort, sounds like its annoyed about the risky setting. Is there a need to have a separate script for ci in this case?

rajmundtoth0 commented 1 month ago

I prefer to have the CI to just display the issues, instead of fixing them. That could prevent unwanted changes. I will add the risky option in a sec.

willpower232 commented 1 month ago

Ah yes I see now, definitely agree with you on that. I don't understand the risky setting but sounds like it would like you to make even more changes :sweat_smile:

rajmundtoth0 commented 1 month ago

In composer I set it to check all folders, while in the original config file, it is looking in only to /src. Now both checks all folders. Hopefully this makes it happy - also formatted the files outside of /src

rajmundtoth0 commented 1 month ago

https://cs.symfony.com/doc/ruleSets/PhpCsFixerRisky.html

parallels999 commented 1 month ago

If you merge this, also merge v13 and v14 so that they are synchronized

willpower232 commented 4 weeks ago

In composer I set it to check all folders, while in the original config file, it is looking in only to /src. Now both checks all folders. Hopefully this makes it happy - also formatted the files outside of /src

The reason it only looks in src is because then it doesn't look in the vendor folder which could be full of all sorts of stuff :sweat_smile:

rajmundtoth0 commented 4 weeks ago

Fixed