search

owen2345 / camaleon-cms

Camaleon CMS is a dynamic and advanced content management system based on Ruby on Rails
https://camaleon.website
MIT License
1.22k stars 287 forks source link

Remove webdrivers gem, which has no support for Chrome v115 #1060

Closed texpert closed 1 year ago

texpert commented 1 year ago

Selenium itself will be automatically managing both browsers and drivers, which is pretty exciting - see https://github.com/titusfortner/webdrivers/issues/247#issuecomment-1648154088

texpert commented 1 year ago

@brian-kephart, I don't think it reasonable to set versions restrictions, except when temporarily not allowing a certain version to be used because of some issues. Let the bundler do its work is the best practice, in general.

Also, selenium-webdriver is still at the 4.10 version, but this is actually working, as stated on the webdrivers discussion:

"Updating to Selenium 4.10 and removing this gem is essentially doing the same as point 2 - you can set the required version for chromedriver to v114 and it will work for Chrome v115 (but will break for Chrome v116)"

Moreover, the 4.11 version of selenium-webdriver will require Ruby 3.xx version, so it will come as a breaking change.

brian-kephart commented 1 year ago

@texpert I largely agree with you. And yeah, if this will be changing over the next few versions of Chrome, then a constraint would just cause more problems than it would solve.