Changing theme reverting back footer info

owen2345 / camaleon-cms

Camaleon CMS is a dynamic and advanced content management system based on Ruby on Rails

https://camaleon.website

MIT License

1.21k stars 285 forks source link

Changing theme reverting back footer info #309

Closed mazharoddin closed 8 years ago

mazharoddin commented 8 years ago

Hi, I am using camaleon_first theme as default theme, I updated footer content after activating the theme, but if I am changing theme to some other theme and reverting back to camaleon_first theme reverting footer content to initial content(default content). Due to this the information I updated in footer getting removed every time if I switch theme.

owen2345 commented 8 years ago

Hi @mazharoddin yes it is, because the old theme is cleaning its custom information that is not necessary for other themes and avoid garbage. You can change this in the method executed after theme inactive

Regards,

mazharoddin commented 8 years ago

Hi @owen2345 , Thanks for the answer, however I feel its better to keep old theme info some where stored, otherwise its would difficult for user to update it whenever he changes the theme.

owen2345 commented 8 years ago

Hi @mazharoddin I think the better solution should add an extra button (update | upgrade or reload) which call in a method of theme to add extra functionality. Remember: each installation of theme create several posttypes, settings, menus, needed. So, this info can be duplicated. What do you think?

mazharoddin commented 8 years ago

Hi @owen2345, Yeah, your solution sounds good, but I feel it would be better we keep each theme configuration specific to that theme, that way each theme can be activated or de-activated as needed, and theme specific data can be retained, so that user no need to re-enter that info again and again.

I feel its better we create separate menu to customize themes similar to wordpress, otherwise managing theme specific options and data will become tough if we add more themes.

screen shot 2016-02-09 at 17 49 49

screen shot 2016-02-09 at 17 46 55

owen2345 commented 8 years ago

you are right! working in it!

mazharoddin commented 8 years ago

Thank you...

mazharoddin commented 8 years ago

Hi @owen2345, please let me know if you got chance to work on this..it may be helpful feature..

owen2345 commented 8 years ago

This is possible by:

Comment the line where you are destroying the theme after uninstall Note: By default camaleon doesn't destroy the theme after uninstall, you need to add like this in your hook for uninstall:

theme.destroy

mazharoddin commented 8 years ago

Ok, Thanks. Also did you got chance to work on adding customization menu to themes, so that themes can be customized.