owen2345 / camaleon-ecommerce

This is an ecommerce plugin for CAMALEON CMS
MIT License
21 stars 20 forks source link

Migrations destroy data #29

Closed p-decoraid closed 8 years ago

p-decoraid commented 8 years ago

Looking at this migration:

https://github.com/owen2345/camaleon-ecommerce/blob/master/db/migrate/20160527184747_add_new_cart_structure.rb

The data in the plugins_order_details table is simply deleted which is not good because we have real orders.

owen2345 commented 8 years ago

OOOOPs I forget to add the migration of current data into new structure before destroy the table. Could you please do it? Regards,

p-decoraid commented 8 years ago

I suppose I don't have much choice in the matter. For reference, this was done in 189584d4.

p-decoraid commented 8 years ago

@owen2345 it looks like the phone number is no longer part of the order information, meaning if a user changes their phone number all orders they have previously placed would show the newly entered phone number. Is this intentional?

p-decoraid commented 8 years ago

Billing address does not have a phone number either. Including a phone number in both shipping and billing addresses seems like a standard practice these days.

owen2345 commented 8 years ago

Also, added phone numbers for shipping and billing addresses.

p-decoraid commented 8 years ago

Thanks!