Some changes to checkout flow - Githubissues

owen2345 / camaleon-ecommerce

This is an ecommerce plugin for CAMALEON CMS

MIT License

21 stars 20 forks source link

Some changes to checkout flow #48

Closed p-decoraid closed 8 years ago

p-decoraid commented 8 years ago

Old flow had some problems:

quantities were decremented after user was charged, creating a possibility of a user paying for something that was out of stock
names did not reflect what the methods did
code was not grouped into methods logically

Changes here:

add a state "qtys_taken" to the cart; this is set after product quantities have been decremented
user is charged after product quantities have been incremented and cart is in qtys_taken state
code that updates amounts and totals in the car moved to its own method
make_paid! renamed to mark_paid, it now just does what its name implies
make_order! renamed to convert_to_order, it aso now only does what its name implies

Also reverts #45, it seems that metas do need to stay attached to carts.