search

owengage / fastnbt

Fast serde serializer and deserializer for Minecraft's NBT and Anvil formats
MIT License
185 stars 35 forks source link

Remove unused fastanvil dependency on hematite-nbt #69

Closed RundownRhino closed 1 year ago

RundownRhino commented 1 year ago

I noticed hematite-nbt in the list of compiled crates and was surprised, since fastnbt does roughly the same. Indeed, it seems to be unused - cargo-udeps agrees, and rg "hematite" doesn't find any mentions of it in the source code. cargo test on the entire workspace passes both before and after the removal.

That dependency was added by https://github.com/owengage/fastnbt/commit/5151cddf3578cb79b2cbb96cf62cc4a3d0f7b884, a commit with no code changes that adds a benchmark comparing fastnbt and hematite-nbt to the readme, so possibly it was added by accident.

owengage commented 1 year ago

Hi there! You're absolutely right. I must have forgotten to remove it when trying to benchmark it alongside fastnbt.

Thanks for your contribution. :)