Panic on `fastanvil::Region::remove_chunk` for a non-existing chunk

owengage / fastnbt

Fast serde serializer and deserializer for Minecraft's NBT and Anvil formats

MIT License

185 stars 35 forks source link

Panic on `fastanvil::Region::remove_chunk` for a non-existing chunk #90

Closed Nemo157 closed 1 year ago

Nemo157 commented 1 year ago

Message:  called `Result::unwrap()` on an `Err` value: 0
Location: cargo\registry\src\index.crates.io-6f17d22bba15001f\fastanvil-0.28.0\src\region.rs:329

I'm guessing it should be checking if the location is 0, 0 already and then just returning.

owengage commented 1 year ago

Hi there @Nemo157. I'm currently on vacation/holiday so won't be getting around to looking at this for a few weeks. Sorry you ran into issues!

Nemo157 commented 1 year ago

Don't worry, these crates have been such a help setting up some tooling for a server. I'll probably submit a PR soon to fix it whenever you get time to review it.