search

owengage / fastnbt

Fast serde serializer and deserializer for Minecraft's NBT and Anvil formats
MIT License
185 stars 35 forks source link

TopShadeRenderer::render returns only transparent on forge chunks #92

Closed suppergerrie2 closed 11 months ago

suppergerrie2 commented 1 year ago

TopShadeRenderer::render assumes forge chunks are not fully generated because the status is minecraft:full instead of full as the code assumes: https://github.com/owengage/fastnbt/blob/8ad72ab3a20e50b921ec14ea2a4cedf82bf24200/fastanvil/src/render.rs#L35-L43

An example region file (generated with Minecraft Forge 47.1.0) that only renders transparent: r.0.0.zip

owengage commented 1 year ago

Thank you for the example data! That's interesting, I'd like to understand why forge makes the status like this rather than the way vanilla seems to. Looks like it's a simple fix though. I will get around to it. :)

suppergerrie2 commented 1 year ago

I'm assuming it is because mods could technically add their own status? I made a local fork to just add 4 more values but with "minecraft:" prefixed and it works fine (other than pink for some unsupported blocks but that was to be expected!)