owengage / fastnbt

Fast serde serializer and deserializer for Minecraft's NBT and Anvil formats
MIT License
185 stars 35 forks source link

Fix forge chunks not rendering #97

Closed suppergerrie2 closed 11 months ago

suppergerrie2 commented 11 months ago

Fix #92 by adding the status strings used by forge to the OK_STATUSES array, this does not change vanilla behaviour as vanilla doesn't use these. Before this change it would only return black colours, after this it returns a rendered image as expected. Result after the change: fixed

owengage commented 11 months ago

Hey, thanks for doing this, and a test to go with it. Sorry I didn't get around to it myself.

suppergerrie2 commented 11 months ago

No problem! Thanks for merging, I've been compiling against a fork with this fix in it and I was going through some PRs for hacktoberfest and remembered I had this still in my fork (did have to make the test). (Talking about hacktoberfest I would appreciate if you added the hacktoberfest-accepted label :) )