search

owenh000 / asciidoctor-multipage

A configurable multipage HTML converter for Asciidoctor
https://owenh.net/asciidoctor-multipage
MIT License
58 stars 23 forks source link

Fixes #13 #14

Closed veselov closed 3 years ago

veselov commented 3 years ago

Fixes #13. I don't have any Ruby experience, so that's the best I could come up with.

owenh000 commented 3 years ago

Hi @veselov,

I don't have any Ruby experience, so that's the best I could come up with.

Well now you do! And thanks for the fix; it looks great. I already merged it.

The only significant change I made was putting the multipage-level attr in the test document header instead, like the other tests. This avoids adding a development dependency for YAML parsing. If you know a compelling reason for using separate YAML files for attributes in the tests, feel free to open another issue where we can discuss it.

veselov commented 3 years ago

Thank you!

The only significant change I made was putting the multipage-level attr in the test document header instead, like the other tests

Ah, I'm quite new to AsciiDoc as well, it didn't strike me that this would have the exact same effect 🤦‍♂