owenl131 / pe

0 stars 0 forks source link

Sequence diagram activation line #12

Open owenl131 opened 1 year ago

owenl131 commented 1 year ago

Sequence diagram shows activation line of Timetable does not end despite already returning the value from the function call.

First alt block has only one clause.

Logic of the first alt block is wrong because this diagram shows that if [size of module list is 0] then a noModuleResponse string is returned to Timetable, but then TimetableDict continues on to get permutations etc. The rest of the logic should have been nested in a second clause of the first alt block.

image.png

nus-se-script commented 1 year ago

Your response not required for this bug as the team has accepted the bug as it is.