owenrumney / go-sarif

Go library for sarif - Static Analysis Results Interchange Format
The Unlicense
66 stars 21 forks source link

chore: update to latest final 2.1.0 #69

Closed spiffcs closed 1 year ago

spiffcs commented 1 year ago

📑 Description

It looks like the 2.1.0 schema was finalized and exists here.

Documents generated with go-sarif using the old schema rtm in the schema field will fail Microsoft's schema validation found here: https://sarifweb.azurewebsites.net/

The diff between rtm and main is immaterial and only consists of description updates.

This change should make the schema field of the generated document valid with upstream tooling =)

✅ Checks

ℹ Additional Information

spiffcs commented 1 year ago

Also happy to update the URL to any other one you might deem more appropriate =)

spiffcs commented 1 year ago

@owenrumney Let me know if there is anything else you need for this PR - happy to make any changes or updates!

owenrumney commented 1 year ago

Thanks for this @spiffcs - I wonder if we should use https://docs.oasis-open.org/sarif/sarif/v2.1.0/errata01/os/schemas/sarif-schema-2.1.0.json for the schema as this appears to be the up-to-date one direct

owenrumney commented 1 year ago

thanks - I can't push to your branch but I've used the commits and used the oasis-open URL in #71

spiffcs commented 1 year ago

Thanks @owenrumney - sorry for missing the follow up!