search

owenthereal / ccat

Colorizing `cat`
https://github.com/owenthereal/ccat
MIT License
3.16k stars 118 forks source link

Added directory check and exit code 1 #40

Closed ladydascalie closed 8 years ago

ladydascalie commented 8 years ago

Hi there, this contains a quick fix for issue #39. Love your tool !

owenthereal commented 8 years ago

@LadyDascalie Thanks for the contribution. Made a few comments.

ladydascalie commented 8 years ago

Good shout @jingweno ! I reworked the check to be smaller and return an error instead so main can handle it as you suggested! Thanks for the code review, I hope this works for you!

ladydascalie commented 8 years ago

Check err and return.

yyaabboopp commented 8 years ago

Thanks @LadyDascalie for this fix and @jingweno for accepting it. How long does it take/what is the process to get this pushed upstream to its brew formulae?

Cheers