owenthereal / codefaces

a web-based source control client
3 stars 2 forks source link

[1.1.1/development] find our ways to do code review remotely #99

Closed owenthereal closed 14 years ago

owenthereal commented 14 years ago

One deadly drawback of remote team is team members can't sync up with what others are doing. We need to find out a way to do code review after every check in. Let's try whether it works under the GItHub's commit review page (Commits -> click on a changeset).

For the guy who pushes the code:

  1. make good comments both on the code (where necessary, don't overly done :)) and on the commit message
  2. group related changes into one commit
  3. make changes according to the reviewer's comments (do they get notified if comments are made in GitHub?)

For the reviewer:

  1. whenever there is a push, review each change and make comments if necessary, comments include concerns, how to improve the code, questions etc.
  2. comment in the whole as done if there is no problem discovered
owenthereal commented 14 years ago

it's easy to sign up for email notification of commit message by using GitHub's service hook: Admin -> Service Hooks -> Email

owenthereal commented 14 years ago

please confirm that you read this task and get email forwarding from codefaces@gmail.com.

owenthereal commented 14 years ago

close