Rename vendored folder from "vendor/_nuts" to "internal"

owenthereal / nut

Vendor Go dependencies

https://github.com/jingweno/nut

MIT License

232 stars 11 forks source link

Rename vendored folder from "vendor/_nuts" to "internal" #11

Open owenthereal opened 9 years ago

owenthereal commented 9 years ago

Currently nut vendors source code to "vendor/_nuts". As discussed in this thread, let's standardize it to "internal". The following changes are needed:

rename the folder to "internal"
don't pull in Go tests for dependencies

The second changes will get go test ./... to work without running dependencies' tests.

dvirsky commented 9 years ago

why not let the user decide on the package name using a command line flag BTW? you can default to internal

owenthereal commented 9 years ago

why not let the user decide on the package name using a command line flag BTW?

As you may read from the discussion linked in the issue, we're trying to standardize the folder of the vendored dependencies across all vendoring tools. I'm afraid this is a hard requirement. The point is that other tools will still work.

dvirsky commented 9 years ago

I agree that this should be the default but there isn't really a reason not to let people override it if they have a good reason to do it. Anyway it's no big deal either way.

dvirsky commented 9 years ago

Did this in #15 - no config, just hard coded