owenthereal / upterm

Instant Terminal Sharing
https://upterm.dev
Apache License 2.0
870 stars 56 forks source link

Client sessions change dimensions of host terminal. #138

Open m0sth8 opened 2 years ago

m0sth8 commented 2 years ago

Hi, thank you for the great project.

I noticed that client sessions, including read-only sessions, affect dimensions of host terminal. (https://github.com/owenthereal/upterm/blob/master/host/internal/server.go#L253) In my case it shouldn't be like that but I wonder if it's something that's expected by other use cases. (e.g. tmux based sessions).

owenthereal commented 1 year ago

👋 You are correct. The dimensions of the host pty change as a new client joins the session. The current algorithm is that the host pty will be set to the smallest width & smallest height of all clients + the host. This might be problematic to the host if a client with a tiny screen size joins.

What would you expect the host size to be for your use cases?