search

owenthereal / upterm

Instant Terminal Sharing
https://upterm.dev
Apache License 2.0
816 stars 53 forks source link

feat: add interactive flag #190

Closed bavarianbidi closed 9 months ago

bavarianbidi commented 9 months ago

to run upterm host without the requrement to automatically accect connections, --interactive=false could be used as flag to skip the command prompt for actively confirming accepting new connections.

WHY: As we are using upterm in combination with github actions to provide a reverse-shell to check failed actions we have to run upterm host without manual user interaction before. For that we've introduced the --interactive flag which we set to false in our use case. We could also think about changing the flag name to --auto-accept-connections to make it more clear what the flag supposed to do.

owenthereal commented 9 months ago

Thanks for your contributions @bavarianbidi! I slightly modified the flag to use -accept instead of -interactive=false to allow automatic acceptance of client connections: https://github.com/owenthereal/upterm/pull/197. It's more user-friendly to define a "positive" flag instead of a "negative" flag IMO.