search

owenthereal / upterm

Instant Terminal Sharing
https://upterm.dev
Apache License 2.0
809 stars 53 forks source link

Distribution-based package formats install binary at the wrong place #247

Closed rlko closed 2 months ago

rlko commented 2 months ago

Greetings, first of all thank you for this project, been using a lot at my corpa job.

I just came here to report you that, I think most, if not all of distribution-based package formats (deb, rpm) are installing the binary in a place that does not belong in the default PATH environment variable.

$ dpkg-deb --contents upterm_linux_amd64.deb
drwxr-xr-x root/root         0 2024-04-17 18:39 ./usr/
-rwxr-xr-x root/root  14704640 2024-04-17 18:38 ./usr/upterm
$ rpm -qlp upterm_linux_amd64.rpm
/usr/upterm

I think you meant to place this in /usr/bin/ and not /usr

It's been like this for quite a while ever since you started making deb/rpm releases basically, and I thought you would eventually figure out with time or someone would report it earlier.

owenthereal commented 2 months ago

Thanks for reporting this. The fix should be rolled out at the next release.