search

owenthereal / upterm

Instant Terminal Sharing
https://upterm.dev
Apache License 2.0
861 stars 56 forks source link

"FLY_APP_NAME is not set" on upgrade #262

Closed Jonher937 closed 6 months ago

Jonher937 commented 6 months ago

Hi, due to the addition of the fly-wrapper and it being set as the default entrypoint here: https://github.com/owenthereal/upterm/blob/1846c3ac2ee368f0419b7bb805b62d33e1e09ae0/Dockerfile.uptermd#L42 upgrade of upterm fails unless the user overrides the entrypoint.

Easy fix for someone that can figure that out, but would have been great to menton in changelog if it was not defaulted to by accident.

A user can override the entrypoint back to uptermd to pass upgrade.

owenthereal commented 6 months ago

This is not desired. I fixed it in https://github.com/owenthereal/upterm/pull/263. Please wait for the new release 0.14.3