owenthewizard / i3lockr

Distort a screenshot and run i3lock
Other
23 stars 6 forks source link

Weird image artifacts with --icon on dual-monitor setup #14

Closed jeffmakes closed 4 years ago

jeffmakes commented 4 years ago

Describe The Bug When I have a second monitor plugged into my laptop, I get weird artifacts with --icon overlay.

To Reproduce i3lockr --blur 20 -u lock-icon.png with this png lock

results in this weirdness s

System Info:

Additional context The overlay is on the primary monitor, as desired.

owenthewizard commented 4 years ago

As a temporary workaround, have you tried using the --ignore-monitors argument with one of the monitors?

jeffmakes commented 4 years ago

Ah, nice workaround, that does get rid of the artifacts. I assumed it would leave the other monitor white/black but it applies the blur effect and looks fine. I can live without the lock symbol on both monitors.

owenthewizard commented 4 years ago

Can you try testing the develop branch? You'll need to change -u to -i.

jeffmakes commented 4 years ago

Ok, that's fixed the artifacts nicely. Looks a lot better, but the icon placement isn't quite right. Unfortunately my screens are now in a different configuration, and I couldn't change the layout because xrandr is the work of satan. Let me know if you'd like to see it in the placement I used before and I'll reboot :D

i3l

owenthewizard commented 4 years ago

I'd be interested in the output of xrandr in the current configuration as well as the output of i3lockr-v--blur 20 -u lock-icon.png. Placement as before on dev branch would be good to see as well.

jeffmakes commented 4 years ago

i3lockr.txt xrandr.txt Logs ^^^. I'll reboot, change the placement and do it again...

jeffmakes commented 4 years ago

i3l i3lockr.txt xrandr.txt

jeffmakes commented 4 years ago

Sorry, accidentally closed the issue there! Right, previous post is close to the original placement, though I've realised that I was actually using a different monitor before, as you can see from the size of the two monitors. I didn't need to reboot - I had srandrd running, which was clobbering my attempts to rearrange things.

owenthewizard commented 4 years ago

I think I see the issue; my code doesn't account for the monitor position. Should be a relatively simple fix, hopefully I'll get to it this weekend.

owenthewizard commented 4 years ago

Would you mind testing the latest commit? Driver issues with my laptop are preventing me from testing with multiple monitors :frowning_face:.

oedm commented 4 years ago

I could test successfully your last commit. Works for me. :+1:

master branch: master

develop branch develop

owenthewizard commented 4 years ago

Excellent, closing this issue and will merge develop into master soon.