owenthewizard / i3lockr

Distort a screenshot and run i3lock
Other
23 stars 6 forks source link

Update cli.yaml to allow new argument. #3

Closed Spencer-H closed 5 years ago

Spencer-H commented 5 years ago

You added the --no-fork flag to the code but didn't tell clap about it so you can't actually use it for anything.

Slightly related, on my machine the 10ms wait isn't long enough, it works about half the time.

owenthewizard commented 5 years ago

--nofork is for i3lock not i3lockr. i3lockr checks if it is passed to i3lock so it knows whether to wait() on i3lock or not. clap never touches those args.

Does that make sense?

Need to find a better solution instead of 10ms wait...

Spencer-H commented 5 years ago

Ah I misunderstood how the arguments between the two interacted, my bad.