search

owenthewizard / i3lockr

Distort a screenshot and run i3lock
Other
23 stars 6 forks source link

xcb-util version update #9

Closed Darkasf closed 5 years ago

Darkasf commented 5 years ago

xcb-util needs to be updated to v0.2.1 from 0.2.0

JohnAZoidberg commented 5 years ago

Would you like to make a PR and test whether the new version still works fine?

Darkasf commented 5 years ago

It didn't actually end up working for me so I went back to i3lock-next for the time being. The --raw option with the resolution was breaking i3lock altogether, after removing that it worked but probably the path to the image was wrong because the default white was displayed.

JohnAZoidberg commented 5 years ago

Did you build i3lock from git? Their latest release is too old for i3lockr, because it doesn't support --raw.

Darkasf commented 5 years ago

Compiling i3lock from git fixed the issue, but the image isn't blurred

Darkasf commented 5 years ago

Actually it looks like all image manipulation is missing since the instead of the lock image it's just the default i3lock circle that's there

JohnAZoidberg commented 5 years ago

Try to build it from the v2 branch and run it with a higher blur factor like i3lockr -b 10. I don't think the i3lockr image is included by default.

JohnAZoidberg commented 5 years ago

@owenthewizard Do you want to make the v2 branch the default? Or merge it into master? It seems to be a lot better than master and you don't have lots of legacy users that depend on an unchanged master ;)

Darkasf commented 5 years ago

The v2 branch dropped the image but it ended up working. Thank you for your time!

owenthewizard commented 5 years ago

@JohnAZoidberg Yes I've been meaning to, I'll do that today.

owenthewizard commented 5 years ago

Done!