search

owenvoke / blade-fontawesome

A package to easily make use of Font Awesome in your Laravel Blade views.
https://packagist.org/packages/owenvoke/blade-fontawesome
MIT License
170 stars 30 forks source link

Path to Sharp icons is incorrect #46

Closed ianlandsman closed 1 year ago

ianlandsman commented 2 years ago

Description

The path to the sharp icons is incorrect, Font Awesome publishes it as "sharp-solid" but this package expects it to be just "sharp".

I would have made a pr for the change, but I wasn't sure how you'd want to handle the solid aspect as I presume they may have set it that way in preparation for sharp-light, sharp-thin, etc (it does say coming soon to these on the site).

owenvoke commented 2 years ago

Feel free to open a PR for this change! 👍🏻 I'm happy to handle it as just without preparing for sharp-light, etc. And we can always revisit it in future if necessary.

sammyaxe commented 1 year ago

any news on this one?

owenvoke commented 1 year ago

@sammyaxe, feel free to PR a change for this if you'd like. 👍🏻

owenvoke commented 1 year ago

This is resolved by https://github.com/owenvoke/blade-fontawesome/pull/56 👍🏻 Released as part of v2.4.0 🚀

The new prefixes are: