search

owenvoke / blade-fontawesome

A package to easily make use of Font Awesome in your Laravel Blade views.
https://packagist.org/packages/owenvoke/blade-fontawesome
MIT License
163 stars 27 forks source link

Fix #6 #7

Closed nguyentranchung closed 4 years ago

nguyentranchung commented 4 years ago

...

codecov[bot] commented 4 years ago

Codecov Report

Merging #7 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master        #7   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity         2         2           
===========================================
  Files              1         1           
  Lines             12        13    +1     
===========================================
+ Hits              12        13    +1
Impacted Files Coverage Δ Complexity Δ
src/BladeFontAwesomeServiceProvider.php 100.00% <100.00%> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eeb9692...55c58c6. Read the comment docs.

nguyentranchung commented 4 years ago

6

driesvints commented 4 years ago

This should be closed as https://github.com/owenvoke/blade-fontawesome/pull/9 provides the correct fix.