search

owenvoke / blade-fontawesome

A package to easily make use of Font Awesome in your Laravel Blade views.
https://packagist.org/packages/owenvoke/blade-fontawesome
MIT License
162 stars 27 forks source link

Remove the dashes from config prefixes #77

Open rynomars opened 3 months ago

rynomars commented 3 months ago

This PR removes the dashes (-) from the prefixes in the config. When you attempt to use the "xxx-sharp" svg an error is encountered.

The blade-ui component documentation states:

It's also important to note that icon prefixes cannot contain dashes (-) as this is the delimiter which we use to split it from the rest of the icon name.

danlapteacru commented 3 months ago

I had the same issue. After removing the dashes (-), everything works well.

owenvoke commented 1 month ago

Hi @rynomars, apologies for the delay on reviewing this.

I think this makes sense to do (I must have overlooked that - isn't allowed in the prefix).

I'm assuming that, if this has always resulted in an error, no one is already using this in existing apps, so it should be safe to rename these (unless it worked with the @svg directive, or if people used the file directly).

I'm not sure if it looks a bit odd having them named fassharp, etc. but I can't think of a good alternative right now.