owickstrom / idris-vimscript

Compile Idris to Vimscript, like you always wanted.
Other
130 stars 5 forks source link

Mega-PR: transpiler optimisations, expanded Vim bindings #1

Closed mrkgnao closed 6 years ago

mrkgnao commented 6 years ago

This includes

The code is badly formatted and needs a lot of uniplate/Control.Lens.Plated love.

mrkgnao commented 6 years ago

Let's start merging this, @owickstrom. The only real outstanding issue is https://github.com/owickstrom/idris-vimscript/issues/6, which I can fix while you're reviewing this PR.

owickstrom commented 6 years ago

@mrkgnao Absolutely!

owickstrom commented 6 years ago

I think the lack of uniplate tricks is fine for now, I'd rather not make the PR any larger. I do have a bunch of pedantic things that would be nice to fix:

Do these things make sense to you?

mrkgnao commented 6 years ago

Do these things make sense to you?

Yes, of course. I'll make sure that this passes the, er, idris-vimscript style guide before it gets merged. :P

Do you have any other code changes to request before I do?

owickstrom commented 6 years ago

Great job, @mrkgnao! 👍 💯

mrkgnao commented 6 years ago

Woohoo!