search

owickstrom / idris-vimscript

Compile Idris to Vimscript, like you always wanted.
Other
130 stars 5 forks source link

Additional flags to disable DCE and TCO #23

Closed adicirstei closed 6 years ago

adicirstei commented 6 years ago

This is the PR addressing #7

The changes are quite substantial. :)

mrkgnao commented 6 years ago

@adicirstei this looks good! Could you please fix the formatting and ensure that it builds with -Werror? The Travis build will continue to fail until you do so.

(cc @owickstrom)

adicirstei commented 6 years ago

I’ll try to do it this weekend. I had no idea I messed the formatting.

Adrian

On 22 Dec 2017, at 20:47, Soham Chowdhury notifications@github.com wrote:

@adicirstei this looks good! Could you please fix the formatting and ensure that it builds with -Werror? The Travis build will continue to fail until you do so.

(cc @owickstrom)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mrkgnao commented 6 years ago

@adicirstei thanks for the fix!

it seems Travis is still failing because of a formatting problem. The logs in the link should help you find out why.

adicirstei commented 6 years ago

Hi,

I don’t know how to read the formatting log. Moreover, didn’t even touched the file Travis is complaining about. Maybe some hints will help. :)

Adrian

On 24 Dec 2017, at 11:27, Soham Chowdhury notifications@github.com wrote:

@adicirstei thanks for the fix!

it seems Travis is still failing because of a formatting problem. The logs in the link should help you find out why.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mrkgnao commented 6 years ago

Sure! If you look at the etc/check-formatting.sh script, it runs every file through hindent -XPatternSynonyms and then stylish-haskell. I'll merge this now and fix it myself.

Thanks for the PR!

owickstrom commented 6 years ago

Good job @adicirstei !

adicirstei commented 6 years ago

Thank you, Oskar! I try to learn.

Adrian

On 26 Dec 2017, at 20:07, Oskar Wickström notifications@github.com wrote:

Good job @adicirstei !

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.