search

owickstrom / idris-vimscript

Compile Idris to Vimscript, like you always wanted.
Other
130 stars 5 forks source link

bring stack up to date, use Idris 1.2.0 #24

Open ababkin opened 6 years ago

mrkgnao commented 6 years ago

Thanks for the PR! We can't merge this as it stands because it's failing the Travis build (see here for why: likely formatting issues).

Outside of that, I think I'd prefer to track the latest version of Idris from Stackage rather than add things to extra-deps unless there's a clear benefit to using the latest available version of Idris.

ababkin commented 6 years ago

Thanks for the comment. I don't see anything in the travis log that tells me what went wrong. Exact same command stack install hlint stylish-haskell hindent idris builds fine locally. Idris 1.1.1 is mostly fixes and optimizations, which seem like good reasons.

ababkin commented 6 years ago

Could you possibly give me a hand fixing this? Or let me know how to go about fixing it?

mrkgnao commented 6 years ago

Oh, I'm so sorry:

Still running (30 of 30): stack install hlint stylish-haskell hindent idris
Timeout (30 minutes) reached. Terminating "stack install hlint stylish-haskell hindent idris"

I think the buildbot failed because compiling idris from source took too long.

mrkgnao commented 6 years ago

I think you should revert the Idris version bump for now. The other changes look good.

ababkin commented 6 years ago

@mrkgnao - It looks like stackage snapshots no longer contain idris package Short of continuing being on the old snapshot, the only way is using external deps

ababkin commented 6 years ago

@mrkgnao - have a question. I'd be happy to play around with the project and contribute, but I have a bit of a hard time starting and understanding the existing code. Is there a good material to read to get into this embedding idris into haskell? (I'm an advanced haskeller but only starting with Idris)

mrkgnao commented 6 years ago

cc @owickstrom: what should we do about this?

@ababkin: I'd suggest you first try looking at the parts that are less involved with the Idris compiler's API, like the optimizations and code transformations. That should give you a feel for what's going on.

owickstrom commented 6 years ago

@mrkgnao Let me try this locally. I might be able to revive the Docker build I worked on to get the Travis build speed up.

owickstrom commented 6 years ago

As a quick hack, I tried separating the installs of hindent and stylish-haskell from idris, which seems to have bypassed the timeout: https://travis-ci.org/owickstrom/idris-vimscript/builds/322139371

owickstrom commented 6 years ago

I'm fiddling around with a Docker + cabal new-build based Travis build also.

ababkin commented 6 years ago

@mrkgnao @owickstrom - was just curious if you guys have figured out the above problem with Travis? Is there a setting for it to not timeout?

owickstrom commented 6 years ago

I haven't had time to do more work on it. The last stuff is on https://github.com/owickstrom/idris-vimscript/tree/update-stack, where I think separating the installations of Idris and other tools helped a bit.