Convert audio names to md5 digest - WIP

owickstrom / komposition

The video editor built for screencasters

https://owickstrom.github.io/komposition/

Mozilla Public License 2.0

428 stars 22 forks source link

Convert audio names to md5 digest - WIP #72

Closed akilegaspi closed 5 years ago

akilegaspi commented 5 years ago

Description: Extracts the base name of the audio file and transforms the base name into an md5 digest

This pull requests fixes #25, by @owickstrom

Make sure to describe (where applicable):

Added pureMD5-2.1.3 Package
Included bytestring Package

Checklist:

Please make sure to check the following items (that are applicable.)

[x] Doesn't duplicate any existing PR
[ ] Automated tests added

How to test:

TODO: Testing instructions for reviewer.

akilegaspi commented 5 years ago

Still have to create automated tests for this one also

akilegaspi commented 5 years ago

Sorry, I haven't been able to checkout the PR for awhile now but ok, so if I understood it correctly, we use the contents of the file to create a hashname for the audio chunk.

Also what do you mean by "non-classifying copy?"

akilegaspi commented 5 years ago

@owickstrom In accordance with #76 , I think it would be better if we created a helper module for generating a hash given Cipher -> Lazy.ByteString -> String since I think it's already given that we both use cryptonite and bytestring packages.

With that being said, it would be easier for us to create tests (using QuickCheck maybe?) for our respective Cipher also.

What do you think?

Cmdv commented 5 years ago

@akilegaspi feel free to help out with the helper function, I started making something but I'm using the file name to do the hashing when I think from comments we need to use the file content?

https://github.com/owickstrom/komposition/pull/76/files#diff-c0ab36ff8cac8d74b3774e1a4cb62225