owickstrom / komposition

The video editor built for screencasters
https://owickstrom.github.io/komposition/
Mozilla Public License 2.0
429 stars 21 forks source link

Make Gap duration adjustable #77

Open Cmdv opened 5 years ago

Cmdv commented 5 years ago

Description:

This pull requests fixes #69

Make sure to describe (where applicable):

screenshot 2019-01-08 at 22 13 59

Checklist:

Please make sure to check the following items (that are applicable.)

How to test: add video gap, select gap and on the sidebar adjust it's duration.

TODO: Testing instructions for reviewer.

Cmdv commented 5 years ago

I managed to get an element added and it displays the correct duration length of the gap. But when I edit nothing update, wondered if I could have some pointers as to how I would adjust the duration of the gap?

I tried to copy clipSpanControl but it looks like it uses VideoAsset which is on the type but this is non existent on VideoGap, does this have something to do with it?

*edit: looks like it would live in here? https://github.com/owickstrom/komposition/blob/f4db3f0547127f3f2cdfd7de0f4be22847ddd70d/src/Komposition/Application/TimelineMode.hs#L190-L196

Cmdv commented 5 years ago

sorry rubber ducking here 🦆 Got the VideoGap state to update so this all works just need to do this to audio gap to then tests 😄

Cmdv commented 5 years ago

Just took another look at this and noticed that "start end" is implemented for the audio as of yet so I won't be able to add this feature to audio gap without implementing that first.

I also can't seem to find a test case where this would live 🤷‍♀️

owickstrom commented 5 years ago

OK, so this would need to use the new undo/redo machinery now, but there are examples already (setting duration of a clip). Would you mind rebasing the PR and implementing it in UndoableAction? Totally get if you don't, I can move it otherwise.

Cmdv commented 5 years ago

yeah not a problem will take a look this evening, I assume the new functionality came in this PR https://github.com/owickstrom/komposition/pull/82 ?

owickstrom commented 5 years ago

@Cmdv that's right :+1: