search

owid / etl

A compute graph for loading and transforming OWID's data
https://docs.owid.io/projects/etl
MIT License
77 stars 21 forks source link

Feature request: Scheduled PR merges #2822

Open spoonerf opened 3 months ago

spoonerf commented 3 months ago

Sometimes, it would be nice to schedule large PRs to merge overnight when no one is working.

PRs that involve large datasets can often block up the etl for a few hours, which can be problematic for others trying to work.

It looks like there are some ways to do it, described here.

Marigold commented 3 months ago

+1! And +100 for finding the tool to do it. I thought we'd have to do it ourselves.

We should make sure that it only merges if CI is ✅ . It's possible that someone changes a chart in prod and chart-diff would start failing.

larsyencken commented 3 months ago

Looks like Lucas already merged something here:

We should check that, and maybe replace it.

stale[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Marigold commented 2 weeks ago

ETL became much faster & robust since we opened this issue. It should be pretty safe to merge in the middle of the day now. It should take less than hour.

Marigold commented 1 week ago

ETL became much faster & robust since we opened this issue. It should be pretty safe to merge in the middle of the day now. It should take less than hour.

@lucasrodes there are more ETL performance improvements on the way. I think we can get to a point where merging anytime is not a big deal, and we wouldn't need this. (Rebuilding full ETL takes ~1 hour now and could be sped up by using PREFER_DOWNLOAD=1 if you have a good connection)

lucasrodes commented 1 week ago

yeah, that makes total sense! thanks for doing that

I would still like to explore this whenever I have some time, and have it be an option.

but based on earlier discussions, and all the performance improvements this a nice to have, and I shouldn't stress much about it :p